Fixes broken links generated on relative URLs #215
Conversation
… markdown Signed-off-by: Maximiliano Churichi <[email protected]>
mchurichi
requested review from
ajessup,
drrt,
evan2645,
sanderson042 and
umairmkhan
as code owners
|
Deploy preview for spiffe ready! Built with commit f10a384 |
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
|
Testing this change, I'm no longer getting 404 errors from GitHub. But if the source file from GitHub has a link to another GitHub page without the file name, the GitHub version of the page is displayed. If the link includes the file name, the spiffe.io version of the GitHub file is displayed as expected. For example, the spiffe/spire-tutorials/k8s/envoy-jwt/README.md file on GitHub has both variants. In that file, this Markdown URL format without the target file name displays the GitHub version of the file: This Markdown URL format with the target file name displays the spiffe.io version of the file, which is the desired behavior: |
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
* In configuring.md, replaced link to k8s Token Review API with different location that doesn't include a version number * In libraries.md, replaced link to archived c-spiffe library with new c-spiffe library under development by HPE Signed-off-by: Steve Anderson <[email protected]>
Signed-off-by: Steve Anderson <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Steve Anderson <[email protected]>
Thanks Max and Andrew for your tweaks to this doc change! Signed-off-by: Steve Anderson <[email protected]>
Signed-off-by: glaucimar <[email protected]>
Signed-off-by: Michael Shen <[email protected]>
… markdown Signed-off-by: Maximiliano Churichi <[email protected]>
Signed-off-by: Maximiliano Churichi <[email protected]>
|
@mchurichi I was looking at some of the PRs to see if I could help - is this still relevant or have things changed too much? |
Fixes #205
Preview site: https://deploy-preview-215--spiffe.netlify.app/docs/latest/microservices/envoy-jwt/readme/
Broken before: https://spiffe.io/docs/latest/microservices/envoy-jwt/readme/ (broken link on
SPIRE Envoy-X.509 Tutorial, on the first sentence)Signed-off-by: Maximiliano Churichi [email protected]