Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding further description of KeyManager #285

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ChaosInTheCRD
Copy link

Description of the change
I began some work to try and make a KeyManager plugin that handed off signing to a CA service in the hope that said service could make policy decisions based on the SVID being presented (e.g., X.509 Certificate Signing request). Of course this does not work, and I misled myself. I am hopeful that this PR will make it more clear for others that hope to do the same thing.

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for spiffe ready!

Name Link
🔨 Latest commit 789297e
🔍 Latest deploy log https://app.netlify.com/sites/spiffe/deploys/64e718f0bc42ea0008f615ff
😎 Deploy Preview https://deploy-preview-285--spiffe.netlify.app/docs/latest/planning/extending
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sanderson042 sanderson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ChaosInTheCRD - Thank you for the PR! My day job is editing and writing software documentation, so here's my take on the wording. Someone else can review the meaning.

content/docs/latest/planning/extending.md Outdated Show resolved Hide resolved
ChaosInTheCRD and others added 3 commits August 24, 2023 09:46
Signed-off-by: chaosinthecrd <[email protected]>
Co-authored-by: Steve Anderson <[email protected]>
Signed-off-by: chaosinthecrd <[email protected]>
Copy link
Contributor

@sanderson042 sanderson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the suggested changes!

Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ChaosInTheCRD for this enhancement in the documentation.
While I think that a clarification about how the Key Manager operates is needed, I would probably word this little differently because IMO it puts some negative emphasis that's not the intent of the section.
Let me discuss this with the SPIRE maintainers team and get back here with the feedback.

Thanks again!

@ChaosInTheCRD
Copy link
Author

Thank you @ChaosInTheCRD for this enhancement in the documentation.

While I think that a clarification about how the Key Manager operates is needed, I would probably word this little differently because IMO it puts some negative emphasis that's not the intent of the section.

Let me discuss this with the SPIRE maintainers team and get back here with the feedback.

Thanks again!

Hey! No problem, it wasn't my intention to make anything sound negative, just to draw a line between what the key manager is and what the upstream authority is ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants