New SyncAuthorizedEntries RPC #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Harding <[email protected]>
azdagron
requested review from
evan2645,
amartinezfayo and
rturner3
as code owners
MarcosDY
reviewed
Nov 6, 2023
Comment on lines
49
to
50
|
|
||
|
|
| @@ -46,6 +46,21 @@ service Entry { | |||
| // The caller must present an active agent X509-SVID. See the Agent | |||
| // AttestAgent/RenewAgent RPCs. | |||
| rpc GetAuthorizedEntries(GetAuthorizedEntriesRequest) returns (GetAuthorizedEntriesResponse); | |||
|
|
|||
|
|
|||
| // Syncs authorized entries down the caller. The caller controls which | |||
There was a problem hiding this comment.
Syncs authorized entries down 'to' the caller.?
| // entries the server sends down full details for. The flow is as follows: | ||
| // 1. Caller opens up sync stream | ||
| // 2. Server determines authorized entries for caller: | ||
| // - If there are less entries than a server-determined page size, go to (5). |
There was a problem hiding this comment.
it is going to 5? or 4?
this means that we get full if we return entries < pagesize?
There was a problem hiding this comment.
To (5). If there aren't many entries, it's not worth trying to do the "diff". The server just sends the full non-sparse set to the agent.
The outcome is that there is no noticeable difference from a network standpoint for existing deployments whose authorized entry sets are smaller than the page size.
Signed-off-by: Andrew Harding <[email protected]>
Signed-off-by: Andrew Harding <[email protected]>
azdagron
force-pushed
the
syncauthorizedentries
branch
from
f9cf2ba
to
8717335
Compare
MarcosDY
approved these changes
Nov 7, 2023
|
Ids not in the authorized set are ignored. |
amartinezfayo
pushed a commit
to amartinezfayo/spire-api-sdk
that referenced
this pull request
Dec 21, 2023
* New SyncAuthorizedEntries RPC Signed-off-by: Andrew Harding <[email protected]> * Fix up comments Signed-off-by: Andrew Harding <[email protected]> * more comments Signed-off-by: Andrew Harding <[email protected]> --------- Signed-off-by: Andrew Harding <[email protected]>
amartinezfayo
pushed a commit
that referenced
this pull request
Dec 21, 2023
* New SyncAuthorizedEntries RPC Signed-off-by: Andrew Harding <[email protected]> * Fix up comments Signed-off-by: Andrew Harding <[email protected]> * more comments Signed-off-by: Andrew Harding <[email protected]> --------- Signed-off-by: Andrew Harding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.