Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalAuthority service: add upstream_authority_subject_key_id field to AuthorityState #65

Merged

Conversation

amartinezfayo
Copy link
Member

@amartinezfayo amartinezfayo commented Aug 23, 2024

  • Add an upstream_authority_subject_key_id field to the AuthorityState message, TaintX509UpstreamAuthorityResponse and RevokeX509UpstreamAuthorityResponse. This helps to improve the experience when tainting upstream authorities, since knowing what's the upstream authority that signed the old local X.509 authority is required to taint an upstream authority.
  • Updated comments about fields that they stated to be optional but they are required.

…o AuthorityState

Signed-off-by: Agustín Martínez Fayó <[email protected]>
…sponse and RevokeX509UpstreamAuthorityResponse

Signed-off-by: Agustín Martínez Fayó <[email protected]>
@amartinezfayo amartinezfayo merged commit 1652699 into spiffe:next Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants