Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable authorization logic #435

Merged
merged 6 commits into from
May 28, 2024
Merged

Add configurable authorization logic #435

merged 6 commits into from
May 28, 2024

Conversation

maia-iyer
Copy link
Collaborator

closes #335 and closes #76

This PR deprecates the AdminViewer authorization option in favor of the configurable RBAC plugin.

It also relaxes one Keycloak-specific detail in the Authenticator "Keycloak" pkg so that it will pass all roles from the bearer token to the Authorization layer.

@maia-iyer maia-iyer added the backend Tornjak API (Backend) label May 19, 2024
@maia-iyer maia-iyer added this to the 1.7.x milestone May 19, 2024
@maia-iyer maia-iyer self-assigned this May 19, 2024
@maia-iyer maia-iyer marked this pull request as ready for review May 21, 2024 19:18
Signed-off-by: Maia Iyer <[email protected]>
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Tested and passed.

@maia-iyer maia-iyer merged commit d184312 into v1.7 May 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Tornjak API (Backend) Ready For Review
Projects
None yet
2 participants