Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tornjak APIs in manager code #508

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Update Tornjak APIs in manager code #508

merged 2 commits into from
Oct 1, 2024

Conversation

maia-iyer
Copy link
Collaborator

Closes #491

@maia-iyer maia-iyer added backend Tornjak API (Backend) manager Tornjak Manager labels Sep 30, 2024
@maia-iyer maia-iyer added this to the 1.9.0 milestone Sep 30, 2024
@maia-iyer maia-iyer self-assigned this Sep 30, 2024
@maia-iyer maia-iyer changed the title add methods to apis in manager code Update Tornjak APIs in manager code Sep 30, 2024
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the unused variable, /lgtm

api/manager/server.go Outdated Show resolved Hide resolved
Signed-off-by: Maia Iyer <[email protected]>
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maia-iyer maia-iyer merged commit b922906 into main Oct 1, 2024
8 checks passed
@maia-iyer maia-iyer deleted the migrate_manager branch October 2, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Tornjak API (Backend) manager Tornjak Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Manager to use Tornjak v1 api
2 participants