add workload delete test and refactor signal handling in run_wasi function #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With #47 this should be ready to test |
rajatjindal
requested review from
Mossaka,
kate-goldenring,
jsturtevant,
radu-matei and
devigned
as code owners
Signed-off-by: Rajat Jindal <[email protected]>
rajatjindal
force-pushed
the
e2e-test
branch
2 times, most recently
from
c15a845 to
8ddac76
Compare
Signed-off-by: Rajat Jindal <[email protected]>
|
requesting review from @Mossaka @jsturtevant @kate-goldenring |
|
Could you update the title of the PR to reflect that it's also changing signal handling logic, please? Thanks! |
rajatjindal
changed the title
rajatjindal
changed the title
jsturtevant
reviewed
Mar 26, 2024
kate-goldenring
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple test case to validate that the pod is deleted successfully in a timely manner.
This PR also moves the signal handling to
run_wasifunction to ensure the pod can be terminated successfully even if the pod was requested to be deleted before therun_triggerfunction had setup the signals. Without this, there was a race condition between setting up of signals and receiving the signal, causing consistent failure on CI with the newly added testcase (and inconsistent failure when running locally)