[draft]: small refactoring of the Spin engine #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radu Matei <[email protected]>
Mossaka
reviewed
Apr 5, 2024
Signed-off-by: Radu Matei <[email protected]>
radu-matei
commented
Apr 8, 2024
| l.config.media_type().to_string() == spin_oci::client::SPIN_APPLICATION_MEDIA_TYPE | ||
| }) | ||
| .context("cannot find locked application in layers for application")?; | ||
| let mut locked_app = LockedApp::from_json(&locked_layer.layer)?; |
There was a problem hiding this comment.
TODO: this should handle archive layers (ref #28)
radu-matei
commented
Apr 8, 2024
| @@ -0,0 +1,133 @@ | |||
| use std::path::{Path, PathBuf}; | |||
There was a problem hiding this comment.
TODO: tests for the new loader.
radu-matei
commented
Apr 8, 2024
containerd-shim-spin/src/engine.rs
Outdated
| } | ||
| } | ||
|
|
||
| #[cfg(test)] |
There was a problem hiding this comment.
TODO: re-add these tests.
radu-matei
commented
Apr 8, 2024
containerd-shim-spin/src/main.rs
Outdated
|
|
||
| fn main() { | ||
| // Configure the shim to have only error level logging for performance improvements. | ||
| let shim_config = Config { | ||
| default_log_level: "error".to_string(), | ||
| // default_log_level: "error".to_string(), |
radu-matei
commented
Apr 8, 2024
containerd-shim-spin/src/engine.rs
Outdated
| use trigger_command::CommandTrigger; | ||
| use trigger_sqs::SqsTrigger; | ||
| // use trigger_command::CommandTrigger; | ||
| // use trigger_sqs::SqsTrigger; |
There was a problem hiding this comment.
TODO: re-enable the command and SQS triggers
Signed-off-by: Radu Matei <[email protected]>
|
I think many of the changes in this PR are good. Do you intend to continue working on this PR, @radu-matei ? |
|
Yes — I would still like to bring these changes in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP of beginning to refactor the Spin engine.
So far, most of this is preference, but this branch will try to address some of the TODOs in the code base eventually.
cc @Mossaka