Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a skip about CRD domains #5

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

calebschoepp
Copy link
Contributor

@calebschoepp calebschoepp commented Jul 11, 2024

See here for a draft of what this change looks like.

Signed-off-by: Caleb Schoepp <[email protected]>
Copy link

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in support of this change. This does make a point that SpinKube sub-projects must all operate under the guise of SpinKube, rather than the other way around. This also ensures that sub-projects can evolve and/or be renamed without having to break apps running in userspace (Kubernetes).

@calebschoepp
Copy link
Contributor Author

I'm looking for an approval from the main SpinKube projects before merging to make sure we have consensus. Tagging the appropriate people to try and get the approvals so we can move this forward.

Runtime Class Manager Maintainers: @flavio OR @voigt OR @0xE282B0 could you please take a look.

@bacongobbler
Copy link

One quick thought here: we don't have documentation anywhere that describes how to upgrade from one version of spin-operator to the next, correct? If so we'd probably want to call out the breaking change in those docs.

I think the docs only talk about how to bootstrap a cluster from scratch, so we don't have to worry too much about upgrade paths, but worth keeping in mind.

Copy link

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this proposal and believe that the early we can do this the better. It will be a breaking change, but it will be less impactful the sooner we do it.

@calebschoepp
Copy link
Contributor Author

In a SpinKube community meeting we had expressed the desire to have approval from each sub-project. The main approval missing is from the runtime-class-manager.

@flavio @0xE282B0 @voigt I'll give y'all to the end of the week to comment and otherwise I'll assume that you have no strong opinions here and I'll go forward with merging this skip.

@calebschoepp calebschoepp merged commit 809bdd8 into spinkube:main Aug 26, 2024
@calebschoepp calebschoepp deleted the new-domain branch August 26, 2024 16:16
adamreese added a commit to adamreese/documentation that referenced this pull request Sep 19, 2024
bacongobbler pushed a commit to adamreese/documentation that referenced this pull request Nov 5, 2024
calebschoepp pushed a commit to calebschoepp/documentation that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants