-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a skip about CRD domains #5
Conversation
Signed-off-by: Caleb Schoepp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in support of this change. This does make a point that SpinKube sub-projects must all operate under the guise of SpinKube, rather than the other way around. This also ensures that sub-projects can evolve and/or be renamed without having to break apps running in userspace (Kubernetes).
One quick thought here: we don't have documentation anywhere that describes how to upgrade from one version of spin-operator to the next, correct? If so we'd probably want to call out the breaking change in those docs. I think the docs only talk about how to bootstrap a cluster from scratch, so we don't have to worry too much about upgrade paths, but worth keeping in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of this proposal and believe that the early we can do this the better. It will be a breaking change, but it will be less impactful the sooner we do it.
In a SpinKube community meeting we had expressed the desire to have approval from each sub-project. The main approval missing is from the runtime-class-manager. @flavio @0xE282B0 @voigt I'll give y'all to the end of the week to comment and otherwise I'll assume that you have no strong opinions here and I'll go forward with merging this skip. |
REF: spinkube/skips#5 spinkube/spin-operator#271 Signed-off-by: Adam Reese <[email protected]>
REF: spinkube/skips#5 spinkube/spin-operator#271 Signed-off-by: Adam Reese <[email protected]> Signed-off-by: Matthew Fisher <[email protected]>
REF: spinkube/skips#5 spinkube/spin-operator#271 Signed-off-by: Adam Reese <[email protected]> Signed-off-by: Matthew Fisher <[email protected]>
See here for a draft of what this change looks like.