First take at getting spintainer working #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really love the name |
I hear that. What would you prefer we call it? |
calebschoepp
force-pushed
the
spintainer
branch
2 times, most recently
from
9019762
to
622bee1
Compare
calebschoepp
requested review from
endocrimes,
bacongobbler,
michelleN and
rajatjindal
as code owners
rajatjindal
reviewed
Sep 12, 2024
rajatjindal
reviewed
Sep 12, 2024
endocrimes
reviewed
Sep 12, 2024
This executor runs SpinApps directly in a docker container rather than via the shim. You can use the default docker images published by the Spin project or you can craft your own images to run custom triggers, Spin versions, plugins, etc. Signed-off-by: Caleb Schoepp <[email protected]>
calebschoepp
force-pushed
the
spintainer
branch
from
cb3bec7
to
fe862a9
Compare
|
Comments addressed — looking for some approvals. |
endocrimes
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spintainer is an alternative executor that runs a spin app in a container rather than via the shim. The user can leverage the image published by the Spin project or they can create their own image. A user might use spintainer if: