Skip to content

Commit

Permalink
Introduce a new namespace attribute to EntityTag
Browse files Browse the repository at this point in the history
The idea being that tag name's could be re-used across namespaces, either
intentionally or accidentally.

Permissions / restrictions could also be applied to namespaces vs. individual
tag names.

Will need to sort out re-indexing and assign a proper namespace to all
existing tags.

Depends on spinnaker/front50#203
  • Loading branch information
ajordens committed Feb 20, 2017
1 parent 7dfc1f7 commit c5c4d0a
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,18 @@ class EntityTags {

static class EntityTag {
String name
String namespace
Object value
EntityTagValueType valueType

String getName() {
return name.toLowerCase()
}

String getNamespace() {
return (namespace ?: "default").toLowerCase()
}

@JsonIgnore
Object getValueForWrite(ObjectMapper objectMapper) {
switch (valueType) {
Expand Down

0 comments on commit c5c4d0a

Please sign in to comment.