fix(gce/internalhttplb) BackendServices for InternalHTTPLb is not hadled correctly

[takaaki7]

spinnaker/spinnaker#6017

[spinnakerbot]

The following commits need their title changed:

• d405078: fix(gce/internalhttplb) backendservices for internalhttplb is not handled correctly

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

[maggieneterval]

Thanks for the fix, @takaaki7! From the issue you created:

BackendService for InternalHTTP must be set at instanceMetadata.region-backend-service-names. But currently it is set at instanceMetadata.backend-service-names

Would you mind elaborating a bit and walking me through this fix? I am not super familiar with this code, and it's tough to feel comfortable merging this change that could potentially break other workflows without a greater understanding given that none of this code is tested or in Typescript.

Thanks!

[xike41]

Is there a way to merge this fix?

[emmanuelstroem]

Thanks for the fix, @takaaki7! From the issue you created:

BackendService for InternalHTTP must be set at instanceMetadata.region-backend-service-names. But currently it is set at instanceMetadata.backend-service-names

Would you mind elaborating a bit and walking me through this fix? I am not super familiar with this code, and it's tough to feel comfortable merging this change that could potentially break other workflows without a greater understanding given that none of this code is tested or in Typescript.

Thanks!

@maggieneterval
I hope this finds you in good health.
I don't suppose @takaaki7 got the chance to explain this.

But Google Cloud Platform has different types of BackendServices (Regional or Global) depending on the type of LoadBalancer one chooses to set up.

There is a detailed table here explaining better than I could with words:
https://cloud.google.com/load-balancing/docs/backend-service

It looks like currently only the global backend service is being catered to.

This PR seems to handling the scenario where there is specifically a regional backendservice configured.