Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(amazon_sqs_subscriber): moved AmazonSQSSubscriberSpec (groovy) unit test to AmazonSQSSubscriberTest (java) #1428

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

aman-agrawal
Copy link
Contributor

@aman-agrawal aman-agrawal commented Jun 15, 2024

  • moved AmazonSQSSubscriberSpec (groovy) unit test to AmazonSQSSubscriberTest (java)
  • Newly added TC is passing in AmazonSQSSubscriberTest
  • deleted AmazonSQSSubscriberSpec
  • changed unmarshalMessageBody() from private to package-private (default) to access it in TC & added @VisibleForTesting
  • added org.mockito:mockito-inline to support creation of static mocks

@aman-agrawal aman-agrawal force-pushed the master branch 2 times, most recently from fbf1cb5 to 82c9b04 Compare July 4, 2024 03:41
…y) unit test to AmazonSQSSubscriberTest (java)
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Jul 19, 2024
@mergify mergify bot added the auto merged label Jul 19, 2024
@mergify mergify bot merged commit 41b334a into spinnaker:master Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants