feat(instrumentation): add instrumentation around echo event handling #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the Gate generated event id as the top level event id in the event being sent to Echo. This conforms to Event.java as used by Echo to deserialize the event upon receipt. This also prevents Echo from generating yet another UUID.
Wire up metrics around before and after manual pipeline execution events sent to Echo. Enable debug logging of specific event ids sent to Echo.
dbyron-sf
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logging and metrics around sending events sent to Echo when a pipeline is triggered manually. Specifically:
As well, this changes the
POST /pipelines/v2/{application}/{pipelineNameOrId}endpoint (the one deck uses to trigger manual execution) to generate an event id before calling echo. Eventually, we may move the event id generation to the UI to reduce the chance of duplicate triggers in some scenarios.