Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mergify): use queue instead of merge (backport #1923) #1924

Open
wants to merge 2 commits into
base: release-1.44.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 20, 2022

This is an automatic backport of pull request #1923 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@link108 link108 added the ready to merge Approved and ready for a merge label Jan 20, 2022
@dbyron-sf
Copy link
Contributor

Well, now this build fails with:

Execution failed for task ':halyard-core:compileJava'.
> Could not resolve all files for configuration ':halyard-core:compileClasspath'.
   > Could not find com.netflix.spinnaker.clouddriver:clouddriver-aws:5.72.1.

     Searched in the following locations:
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
       - https://repo.maven.apache.org/maven2/com/netflix/spinnaker/clouddriver/clouddriver-aws/5.72.1/clouddriver-aws-5.72.1.pom
Use '--warning-mode all' to show the individual deprecation warnings.
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project :halyard-core

so we're back to changing to dependencies that exist in maven central only....like #1894 and some other PRs do. Do we really need to go down this road?

@juanpabloprado
Copy link
Contributor

Well, now this build fails with:

Execution failed for task ':halyard-core:compileJava'.
> Could not resolve all files for configuration ':halyard-core:compileClasspath'.
   > Could not find com.netflix.spinnaker.clouddriver:clouddriver-aws:5.72.1.

     Searched in the following locations:
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
       - https://repo.maven.apache.org/maven2/com/netflix/spinnaker/clouddriver/clouddriver-aws/5.72.1/clouddriver-aws-5.72.1.pom
Use '--warning-mode all' to show the individual deprecation warnings.
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project :halyard-core

so we're back to changing to dependencies that exist in maven central only....like #1894 and some other PRs do. Do we really need to go down this road?

Is it possible to push version 5.72.1 on to mvn repo i.e. https://mvnrepository.com/artifact/com.netflix.spinnaker.clouddriver/clouddriver-aws?repo=bt-spinnaker so it can fetch https://repo.maven.apache.org/maven2/com/netflix/spinnaker/clouddriver/clouddriver-aws/5.72.1/clouddriver-aws-5.72.1.pom as a quick fix

@dbyron-sf
Copy link
Contributor

Is it possible to push version 5.72.1 on to mvn repo i.e. https://mvnrepository.com/artifact/com.netflix.spinnaker.clouddriver/clouddriver-aws?repo=bt-spinnaker so it can fetch https://repo.maven.apache.org/maven2/com/netflix/spinnaker/clouddriver/clouddriver-aws/5.72.1/clouddriver-aws-5.72.1.pom as a quick fix

I don't know a great way to do that. I don't have the artifacts to push...which would mean re-building them and then publishing them. I suppose we could try deleting the tag and re-creating it...but I suspect there will be more artifacts after this one that are missing, including some that we don't normally build, nor publish ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Approved and ready for a merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants