fix(jenkins): Using null breaks the cache mechanism (#939)

spinnaker · May 11, 2021 · f61b499 · f61b499
1 parent ef6173b
commit f61b499
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/igor-web/src/main/groovy/com/netflix/spinnaker/igor/build/BuildController.groovy b/igor-web/src/main/groovy/com/netflix/spinnaker/igor/build/BuildController.groovy
@@ -201,7 +201,8 @@ class BuildController {
       HandlerMapping.PATH_WITHIN_HANDLER_MAPPING_ATTRIBUTE)).split('/').drop(4).join('/')
 
     String pendingKey = computePendingBuildKey(master, job, requestParams, startTime)
-    String buildNumber = null
+    // Initializing buildNumber to null will get it silently casted to "null" down the line
+    String buildNumber = ""
 
     PendingOperationsCache.OperationState pendingStatus = pendingOperationsCache.getAndSetOperationStatus(pendingKey, PendingOperationsCache.OperationStatus.PENDING, "")
     if (pendingStatus.status == PendingOperationsCache.OperationStatus.PENDING) {