add cpu and memory constraints #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoqo
reviewed
Apr 10, 2022
README.md
Outdated
| @@ -79,7 +79,9 @@ curl -X POST http://localhost:4434/createservice \ | |||
| "type": "postgres", | |||
| "name": "localtest", | |||
| "username": "spinup", | |||
| "password": "spinup" | |||
| "password": "spinup", | |||
| "memory": "6000", //In Megabytes | |||
There was a problem hiding this comment.
So this is 6GB, correct? was curious if someone is running it on say...a system with < 6GB, what would docker do in that case?
There was a problem hiding this comment.
right,will have to add error messages for edge cases like this
There was a problem hiding this comment.
Yeah, was just curious anyway. Since this is just an example and users can adjust based on their system...it should likely be fine, plus creating the container will probably fail
viggy28
requested changes
Apr 10, 2022
viggy28
requested changes
Apr 10, 2022
skant7
force-pushed
the
feature/resource-constraints
branch
from
760c3f4
to
b276190
Compare
viggy28
approved these changes
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the feature to restrict memory and CPU resource constraints and partially addresses #22