Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stroke-dashArray functionally. #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,15 @@ line.setPoints(geometry, p => 2); // makes width 2 * lineWidth
line.setPoints(geometry, p => 1 - p); // makes width taper
line.setPoints(geometry, p => 2 + Math.sin(50 * p)); // makes width sinusoidal
```
Should we want to use a dashed array similar to the css command stroke-dasharray, we can supply an object with the number of points we require to be shown / hidden and the total line width:

```js

const dashObj = { dashArray: [2,4,6,8,2], width:2 }

const line = new MeshLine ();
line.setGeometry (geometry, dashObj)
```

##### Create a MeshLineMaterial #####

Expand Down
25 changes: 23 additions & 2 deletions src/THREE.MeshLine.js
Original file line number Diff line number Diff line change
Expand Up @@ -222,14 +222,35 @@
this.previous.push(v[0], v[1], v[2])
this.previous.push(v[0], v[1], v[2])


this.makeDashArray = function (p,dashObj) {
// A function to allow dashed arrays

const total = dashObj.dashArray.reduce ((partialSum, a) => partialSum + a, 0);
const state = p % total;

var talley = dashObj.dashArray[0];
for (let i = 1; i < dashObj.dashArray.length; i++) {
if (state > talley) { // odd even
return dashObj.width * (i % 2);
}
talley += dashObj.dashArray[i];
}
}


for (var j = 0; j < l; j++) {
// sides
this.side.push(1)
this.side.push(-1)

// widths
if (this.widthCallback) w = this.widthCallback(j / (l - 1))
else w = 1
if (typeof this.widthCallback == 'function') {
w = this.widthCallback(j / (l - 1))
} else if (typeof this.widthCallback == 'object'){
w = this.makeDashArray(j,this.widthCallback)
} else w = 1

this.width.push(w)
this.width.push(w)

Expand Down