-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bitmap-ray and sprite-ray collision functions #198
Open
matt439
wants to merge
19
commits into
splashkit:develop
Choose a base branch
from
matt439:ray-bitmap
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meters, and update collision logic with ray thickness constant
…r improved clarity
… and overload for additional parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There has been growing interest in using SplashKit to perform ray-tracing in both 2D and 3D environments. However, there is a lack of ray-based functions, particularly with detecting pixel-based collisions. I have added bitmap-ray and sprite-ray functions which will allow for more advanced ray-tracing, going beyond the primitive shapes.
quad_from
This function constructs a quad around a passed-in segment. The width of the quad along the segment is also passed in as an argument.
bitmap_quad_collision
I made use of a function which I previously developed and submitted in a previous PR: #197. Unlike in the previous PR, I did not include the 4 overloads in this PR.
bitmap_bounding_circle bug fix
bitmap_ray_collision
callsbitmap_bounding_circle
which contains a bug. The bug was detected and fixed in a previous PR: #195. I copied the bug fix into this PR as it was necessary for accurate functioning ofbitmap_ray_collision
.Type of change
How Has This Been Tested?
I added two new tests to
sktest
: one in each oftest_geometry.cpp
andtest_sprites.cpp
. These real-time graphical tests allow the user to control a ray by using the arrow keys and mouse. There are bitmaps and sprites in their respective tests which indicate whether a collision has occurred.Testing Checklist
Checklist