Flag sets #100
Merged
Flag sets #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmelograno
approved these changes
Oct 30, 2023
EmilianoSanchez
requested changes
Oct 30, 2023
.github/workflows/ci-cd.yml
Outdated
| @@ -47,7 +47,7 @@ jobs: | |||
| run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") npm run build | |||
|
|
|||
| - name: Store assets | |||
| if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/development' || github.ref == 'refs/heads/main') }} | |||
| if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/sdks-7668' || github.ref == 'refs/heads/main') }} | |||
There was a problem hiding this comment.
sdks-7668 -> development
EmilianoSanchez
approved these changes
Oct 31, 2023
EmilianoSanchez
requested changes
Nov 1, 2023
| @@ -801,7 +801,7 @@ declare namespace SplitIO { | |||
| * | |||
| * @typedef {string} SplitFilterType | |||
| */ | |||
| type SplitFilterType = 'byName' | 'byPrefix'; | |||
| type SplitFilterType = 'bySet' | 'byName' | 'byPrefix'; | |||
There was a problem hiding this comment.
missing the sets property in SplitView type.
Check splitio/react-native-client#71
[SDKS-7657] Update commons version & changes file
mmelograno
approved these changes
Nov 3, 2023
EmilianoSanchez
approved these changes
Nov 3, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS Browser SDK
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes