Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag sets #771

Merged
merged 57 commits into from
Dec 4, 2023
Merged

Flag sets #771

merged 57 commits into from
Dec 4, 2023

Conversation

emmaz90
Copy link
Contributor

@emmaz90 emmaz90 commented Oct 24, 2023

JS SDK

What did you accomplish?

How do we test the changes introduced in this PR?

Extra Notes

Emmanuel Zamora and others added 19 commits September 28, 2023 11:59
[SDKS-7563] stabilize integration tests for flag sets
33cdcab
Update commons rc version
a2fa07a
Improve ready from cache tests
b7b8434
@emmaz90
Merge pull request #762 from splitio/sdks-7563
079e733 
[SDKS-7563] Stabilize integration tests
[SDKS-7564] Flag sets integration tests
c510e36
[SDKS-7567] Add type definitions
b9fab93
Fix typo in splitChanges file
933bcf2
Fix flag sets typo
03bff12
Merge branch 'sdks-7564' of https://github.com/splitio/javascript-client
c30720f 
 into sdks-7567
Integration tests improvements
602fc7f
Merge branch 'sdks-7564' of https://github.com/splitio/javascript-client
691f92f 
 into sdks-7567
Merge branch 'development' of https://github.com/splitio/javascript-c…
e28b1fd 
…lient into sdks-7437
Update commons version
7f95c92
Merge branch 'sdks-7437' into sdks-7564
ae4c2b5
Fix missing post
97b4da9
Merge branch 'sdks-7564' of https://github.com/splitio/javascript-client
936dc8b 
 into sdks-7567
@emmaz90
Merge pull request #763 from splitio/sdks-7564
66ddb34 
[SDKS-7564] Flag sets integration tests
@emmaz90
Merge pull request #764 from splitio/sdks-7567
a3045ec 
[SDKS-7567] Add type definitions
Update rc version
1912e9f
@emmaz90 emmaz90 requested a review from a team as a code owner October 24, 2023 19:13
EmilianoSanchez
EmilianoSanchez requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment to check before merging.
Also add the changelog entry for the changes you did.

.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
@EmilianoSanchez EmilianoSanchez mentioned this pull request Oct 31, 2023
Merged
EmilianoSanchez
EmilianoSanchez requested changes Nov 1, 2023
View reviewed changes
types/splitio.d.ts Show resolved Hide resolved
Emmanuel Zamora and others added 26 commits November 2, 2023 23:57
Merge branch 'development' of https://github.com/splitio/javascript-c…
101d504 
…lient into sdks-7437
update rc version
83e5705
fix lint
ebb98d2
New mock for flagsets
c45244a
Adding redis tests part1 for flagsets, this wont work without commons
d13fdcc
@EmilianoSanchez
add test to validate that NodeJS SDK times out when a client-side SDK…
bc22063 
… key is provided
@EmilianoSanchez
add changelog entry
eb43b58
@EmilianoSanchez
validate ready promise rejection
bbad0a4
@EmilianoSanchez
Merge pull request #775 from splitio/fix_sdk_key_validation
f9728ca 
Update SDK key validation in NodeJS
add tests with configs and telemetry latency validations
ddeef83
merging changes
e611cff
Release v10.24.0-beta
65572e9
fix changes file
8040348
@emmaz90
Merge pull request #776 from splitio/beta
886a31c 
Release v10.24.0-beta
@EmilianoSanchez
Update E2E tests to validate flag sets support in consumer mode
e58c8f9
@EmilianoSanchez
Merge branch 'fix_sdk_key_validation' into sdks-7437
12a0741
@EmilianoSanchez
Merge branch 'sdks-7437' into SDKS-7796-flagsets_in_redis_storage
98c7c93
@EmilianoSanchez
Merge branch 'sdks-7437' into sdks-7658
0923a26
@EmilianoSanchez
Add manager method asserts for consumer mode with Redis
3cd341f
@EmilianoSanchez
Updates
9fee387
@EmilianoSanchez
Revert validation of flag sets evaluation, to merge with branch sdks-…
7c4eb1b 
…7658
@EmilianoSanchez
Merge branch 'SDKS-7796-flagsets_in_redis_storage' into sdks-7658
36e51a5
@EmilianoSanchez
Fix tests and prepare rc
550261f
@EmilianoSanchez
rc with log fixes
6118ecf
@EmilianoSanchez
Rollback ci-cd config
e659032
@EmilianoSanchez
Merge pull request #774 from splitio/sdks-7658
e039a7c 
[SDKS-7658][SDKS-7796] Add flag sets support for Redis storage
@EmilianoSanchez EmilianoSanchez merged commit b927fac into development Dec 4, 2023
7 checks passed
@EmilianoSanchez EmilianoSanchez deleted the sdks-7437 branch December 4, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sennhann29 sennhann29 sennhann29 approved these changes

@EmilianoSanchez EmilianoSanchez EmilianoSanchez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmaz90 @EmilianoSanchez @sennhann29