Skip to content

Commit

Permalink
Fix CI
Browse files Browse the repository at this point in the history
A recent change in `rspec-expectations` has caused the tests to start
failing in CI. It seems that `an_array_matching` is no longer an
AliasedMatcher but is a direct instance of our MatchArray class. I am
not sure why this happens, but I do know that tests start failing at
3.12.4. Rolling back to 3.12.3 fixes the error temporarily.
  • Loading branch information
mcmire committed Feb 5, 2024
1 parent d144751 commit 7e6dc1e
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 5 deletions.
8 changes: 7 additions & 1 deletion Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,13 @@ appraisals = {
proc do |with_rails|
version = [">= 3.10", "< 4"]

gem "rspec", *version
# gem "rspec", *version

gem "rspec", "3.12.0"
gem "rspec-core", "3.12.0"
gem "rspec-expectations", "3.12.3"
gem "rspec-mocks", "3.12.0"
gem "rspec-support", "3.12.0"

gem "rspec-rails" if with_rails
end
Expand Down
6 changes: 5 additions & 1 deletion gemfiles/no_rails_rspec_gte_3_10.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ gem "syntax_tree"
gem "syntax_tree-haml"
gem "syntax_tree-rbs"
gem "warnings_logger"
gem "rspec", ">= 3.10", "< 4"
gem "rspec", "3.12.0"
gem "rspec-core", "3.12.0"
gem "rspec-expectations", "3.12.3"
gem "rspec-mocks", "3.12.0"
gem "rspec-support", "3.12.0"

gemspec path: "../"
6 changes: 5 additions & 1 deletion gemfiles/rails_6_0_rspec_gte_3_10.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ gem "net-ftp"
gem "combustion"
gem "rails", "~> 6.0.0"
gem "sqlite3", "~> 1.4.0", platform: [:ruby, :mswin, :mingw]
gem "rspec", ">= 3.10", "< 4"
gem "rspec", "3.12.0"
gem "rspec-core", "3.12.0"
gem "rspec-expectations", "3.12.3"
gem "rspec-mocks", "3.12.0"
gem "rspec-support", "3.12.0"
gem "rspec-rails"

gemspec path: "../"
6 changes: 5 additions & 1 deletion gemfiles/rails_6_1_rspec_gte_3_10.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ gem "net-ftp"
gem "combustion"
gem "rails", "~> 6.1.0"
gem "sqlite3", "~> 1.4.0", platform: [:ruby, :mswin, :mingw]
gem "rspec", ">= 3.10", "< 4"
gem "rspec", "3.12.0"
gem "rspec-core", "3.12.0"
gem "rspec-expectations", "3.12.3"
gem "rspec-mocks", "3.12.0"
gem "rspec-support", "3.12.0"
gem "rspec-rails"

gemspec path: "../"
6 changes: 5 additions & 1 deletion gemfiles/rails_7_0_rspec_gte_3_10.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ gem "net-ftp"
gem "combustion"
gem "rails", "~> 7.0.0"
gem "sqlite3", "~> 1.4.0", platform: [:ruby, :mswin, :mingw]
gem "rspec", ">= 3.10", "< 4"
gem "rspec", "3.12.0"
gem "rspec-core", "3.12.0"
gem "rspec-expectations", "3.12.3"
gem "rspec-mocks", "3.12.0"
gem "rspec-support", "3.12.0"
gem "rspec-rails"

gemspec path: "../"

0 comments on commit 7e6dc1e

Please sign in to comment.