Skip to content

Commit

Permalink
Revert "Use Zeus to run integration tests on CI (#212)"
Browse files Browse the repository at this point in the history
This reverts commit 9e46160.

Unfortunately, Zeus is just not reliable enough to run on CI. It's not
even reliable locally. Sometimes tests will hang for no reason, and
sometimes Zeus will fail with errors like `read unix ->: recvmsg:
message too long`. And unfortunately, once Zeus fails, the best way to
fix it is to restart it. This isn't possible to do in CI tests, and
adding some kind of "with Zeus, then without Zeus" strategy to tests
would add complexity I don't want. I'll have to find a better way.
  • Loading branch information
mcmire committed Feb 5, 2024
1 parent d144751 commit 8ee29f3
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions .github/workflows/super_diff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,16 +103,5 @@ jobs:
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Install Zeus
run: gem install zeus
- name: Start Zeus
uses: JarvusInnovations/background-action@v1
with:
run: zeus start
wait-on: |
socket:.zeus.sock
file:.zeus.sock
wait-for: 15s
log-output-if: failure
- name: Run tests
run: bundle exec rake --trace

0 comments on commit 8ee29f3

Please sign in to comment.