Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS Graph Office365: PAPP-27394 - Bug fix #29

Merged
merged 88 commits into from
Jun 28, 2023

Conversation

ighelani-crest
Copy link
Contributor

@ighelani-crest ighelani-crest commented Sep 22, 2022

NOTE :
The static pipeline is failing as the update playbooks are yet not merged in the next branch, once playbooks are merged it will pass.

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The readme.html has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the readme.html.
  • If this is a new connector or you are adding new actions
    • Please document in the readme.html all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the readme.html.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)


Thanks for contributing!

office365.json Outdated Show resolved Hide resolved
@hardik-crest
Copy link
Contributor

Any update on this pull request? It's been opened for a while, and blocks the 'send email' action

Hello, @alnumac
The development is done and testing in almost completed. Will be releasing this app soon.

Copy link

@tonyc-phantom tonyc-phantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upgrade the django package in requirements.txt to 3.2.19 due to this vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2023-31047.

requirements.txt Outdated Show resolved Hide resolved
@ishans-crest ishans-crest merged commit 5a2481c into next Jun 28, 2023
@ishans-crest ishans-crest deleted the ighelani_PAPP-27394_bug_fix branch June 28, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.