-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(custom_row): pass default row value to custom row component #1218
Conversation
@soleksy-splunk can you please review this and merge if you are okay with the change? |
we can merge that one but as a part of that ticket we agreed to do other modifications as this is an improvement but still does not fix issue that was raised with me. To solve it we agreed that method @rohanm-crest not sure if you want to include it inside that PR or create a fresh new one. (i'm fine with either) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a look at those comments, not something crucial but imo nice to have. obviously feel free to argue and dismiss comment
...ackage_global_config_everything/package/appserver/static/js/build/custom/custom_input_row.js
Show resolved
Hide resolved
Don't forget to update the title |
**Issue number: ADDON-70909
Summary
Changes
User experience
Checklist