-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(configuration): display UCC version #1221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtsvetkov-splunk
force-pushed
the
feature/ucc-version-on-ui
branch
from
June 4, 2024 08:22
e5ea575
to
99d416c
Compare
vtsvetkov-splunk
force-pushed
the
feature/ucc-version-on-ui
branch
from
June 4, 2024 09:39
99d416c
to
6812135
Compare
…re/ucc-version-on-ui
…feature/ucc-version-on-ui
artemrys
reviewed
Jun 4, 2024
…re/ucc-version-on-ui # Conflicts: # ui/src/pages/Configuration/stories/__images__/ConfigurationPage-configuration-page-view-chromium.png # ui/src/pages/stories/__images__/GlobalConfigPlayground-global-config-playground-chromium.png
soleksy-splunk
previously approved these changes
Jun 5, 2024
I just wanted to add a simple test for Configuration page and I had to fix a lot of underlying components to make it work... |
artemrys
approved these changes
Jun 5, 2024
soleksy-splunk
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
artemrys
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-71111
Summary
Changes
meta
of globalConfig.json to opt out of this labelUser experience
User would observe the label "Made with UCC v" near OpenAPI.json button on the configuration page
small screen
(this one bugs me, but I want to reorganize the layout in separate task)normal screen
on hover state
Checklist
If your change doesn't seem to apply, please leave them unchecked.