refactor: add Typescript support for some files #1303

rohanm-crest · 2024-07-30T12:24:55Z

Issue number: ADDON-71889

Summary

Changes

Converted javascript files into typescript.

User experience

There is no changes that reflects user experience

Checklist

If your change doesn't seem to apply, please leave them unchecked.

I have performed a self-review of this change
Changes have been tested
Changes are documented
PR title follows conventional commit semantics

vtsvetkov-splunk

Since this is in a draft state, I haven't commented on many issues, assuming you'll address them as the PR matures. Let me know when you're ready for a more detailed review

ui/src/types/globalConfig/pages.ts

ui/src/pages/Input/InputPage.tsx

ui/src/components/BaseFormView/BaseFormConfigMock.ts

ui/src/components/CustomControl.tsx

ui/src/components/CustomTab/CustomTab.tsx

ui/src/pages/Configuration/ConfigurationPage.tsx

ui/src/pages/Input/InputPage.tsx

ui/src/components/CustomControl.tsx

ui/src/components/table/CustomTable.tsx

ui/src/pages/Input/InputPage.tsx

ui/src/pages/Configuration/ConfigurationPage.tsx

ui/src/pages/Input/InputPage.tsx

ui/src/util/configManager.tsx

tests/testdata/test_addons/package_global_config_everything/globalConfig.json

ui/src/components/table/tests/TableWrapper.test.tsx

docs/inputs/index.md

ui/src/components/table/CustomTable.tsx

ui/src/pages/Input/InputPage.tsx

ui/src/components/table/useTableSort.ts

docs/inputs/index.md

tests/testdata/test_addons/package_global_config_everything/globalConfig.json

splunk_add_on_ucc_framework/schema/schema.json

ui/src/components/CheckboxGroup/checkboxGroupMocks.json

ui/src/components/CheckboxGroup/checkboxGroupRequiredMocks.json

ui/src/components/CustomControl.tsx

ui/src/types/globalConfig/pages.ts

ui/src/pages/Input/InputPage.tsx

ui/src/types/globalConfig/pages.ts

ui/src/pages/Input/InputPage.tsx

ui/src/pages/Configuration/ConfigurationPage.tsx

ui/src/pages/Input/InputPage.tsx

…addonfactory-ucc-generator into ADDON-71889-refactor-jsx

rohanm-crest self-assigned this Jul 30, 2024

refactor(code): ADDON-71889: convert jsx files into tsx

ed2f5b2

rohanm-crest force-pushed the ADDON-71889-refactor-jsx branch from 114e190 to ed2f5b2 Compare July 31, 2024 06:17

vtsvetkov-splunk requested changes Jul 31, 2024

View reviewed changes

rohanm-crest added 2 commits August 3, 2024 22:10

refactor(code): refactor typescript files

a9e9d88

Merge branch 'develop' into ADDON-71889-refactor-jsx

1c85c7e

vtsvetkov-splunk reviewed Aug 5, 2024

View reviewed changes

rohanm-crest added 4 commits August 7, 2024 19:07

refactor: solve globalconfig error and refactor code for tsx files

5e158a4

chore: changed type for mode

5120fa4

fix(snapshot): fix storybook input page issue

9795651

chore: added commented code

b5c00b5

rohanm-crest marked this pull request as ready for review August 8, 2024 09:17

rohanm-crest requested review from a team as code owners August 8, 2024 09:17

docs(inputspage): added type for input page

aba30a0

rohanm-crest requested a review from vtsvetkov-splunk August 8, 2024 12:08

vtsvetkov-splunk reviewed Aug 9, 2024

View reviewed changes

rohanm-crest added 4 commits August 13, 2024 22:55

fix(type): remove the type literal from schema.json and other files

bbe7b37

fix: sort test case for tablewrapper

4e315ec

merge develop

d8982ac

chore: remove minor type check for customtable

7fa6643

rohanm-crest requested a review from vtsvetkov-splunk August 14, 2024 05:42

vtsvetkov-splunk requested changes Aug 14, 2024

View reviewed changes

ui/src/pages/Input/InputPage.tsx Outdated Show resolved Hide resolved

ui/src/types/globalConfig/pages.ts Show resolved Hide resolved

ui/src/types/globalConfig/pages.ts Show resolved Hide resolved

rohanm-crest and others added 4 commits August 16, 2024 14:39

Merge branch 'develop' into ADDON-71889-refactor-jsx

b65778e

refactor: removed unwanted code

b5c549c

refactor: added the type literal for input page

f51df6d

chore: added newline in files

741f898

vtsvetkov-splunk requested changes Aug 20, 2024

View reviewed changes

vtsvetkov-splunk reviewed Aug 20, 2024

View reviewed changes

ui/src/pages/Configuration/ConfigurationPage.tsx Outdated Show resolved Hide resolved

ui/src/pages/Input/InputPage.tsx Outdated Show resolved Hide resolved

ui/src/pages/Input/InputPage.tsx Outdated Show resolved Hide resolved

ui/src/pages/Input/InputPage.tsx Show resolved Hide resolved

rohanm-crest requested a review from vtsvetkov-splunk August 20, 2024 17:37

rohanm-crest and others added 6 commits August 21, 2024 10:49

Merge branch 'develop' into ADDON-71889-refactor-jsx

2c39cb8

fix: remove type literal from zod schema

ced4bc8

Merge branch 'develop' into ADDON-71889-refactor-jsx

c627d40

Merge branch 'develop' into ADDON-71889-refactor-jsx

1b34e66

merge with develop

7cd441c

Merge branch 'ADDON-71889-refactor-jsx' of https://github.com/splunk/…

2f97d4d

…addonfactory-ucc-generator into ADDON-71889-refactor-jsx

vtsvetkov-splunk approved these changes Aug 21, 2024

View reviewed changes

vtsvetkov-splunk changed the title ~~refactor(code): refactor JSX files for TypeScript support~~ refactor: add Typescript support for some files Aug 21, 2024

vtsvetkov-splunk merged commit 32c34e5 into develop Aug 21, 2024
76 checks passed

vtsvetkov-splunk deleted the ADDON-71889-refactor-jsx branch August 21, 2024 12:06

github-actions bot locked and limited conversation to collaborators Aug 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: add Typescript support for some files #1303

refactor: add Typescript support for some files #1303

rohanm-crest commented Jul 30, 2024

vtsvetkov-splunk left a comment

refactor: add Typescript support for some files #1303

refactor: add Typescript support for some files #1303

Conversation

rohanm-crest commented Jul 30, 2024

Summary

Changes

User experience

Checklist

vtsvetkov-splunk left a comment

Choose a reason for hiding this comment