fix: custom row loading on many tabs #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtsvetkov-splunk
previously approved these changes
Sep 11, 2024
|
Can we also add the test case for this in the globalConfig present in everything folder? |
soleksy-splunk
force-pushed
the
fix--custom-row-loading-on-config-page
branch
from
cc63ee5 to
b1b36c6
Compare
This reverts commit b1b36c6.
sgoral-splunk
previously approved these changes
Sep 18, 2024
splunk_add_on_ucc_framework/commands/rest_builder/global_config_builder_schema.py
Outdated
Show resolved
Hide resolved
sgoral-splunk
previously approved these changes
Sep 18, 2024
vtsvetkov-splunk
approved these changes
Sep 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
https://splunk.atlassian.net/browse/ADDON-75045
Summary
fixes issue that for every tab custom row was loaded from inputs.table object
add tab for configuration page with custom rows
Changes
User experience
custom rows for config page should work right now
Checklist
If your change doesn't seem to apply, please leave them unchecked.