Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: new add-on passes AppInspect #1501

Merged
merged 9 commits into from
Jan 3, 2025
Merged

ci: new add-on passes AppInspect #1501

merged 9 commits into from
Jan 3, 2025

Conversation

artemrys
Copy link
Member

@artemrys artemrys commented Dec 3, 2024

Issue number: N/A

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

Introduce a new test to verify that the new add-on (init -> build -> package) passes Splunk's AppInspect checks.

It contains one hack

echo "# Binary File Declaration\n\nIgnoring lib/charset_normalizer/md.cpython-37m-x86_64-linux-gnu.so" > demo_addon_for_splunk/package/README.txt

to make sure we actually pass AppInspect checks.

We will need to follow up on it with the team and see how this can be solved long-term.

User experience

N/A

Checklist

If an item doesn't apply to your changes, leave it unchecked.

@artemrys artemrys changed the title Init build appinspect ci: new add-on passes AppInspect Jan 3, 2025
@artemrys artemrys marked this pull request as ready for review January 3, 2025 13:25
@artemrys artemrys requested a review from a team as a code owner January 3, 2025 13:25
@artemrys artemrys merged commit f6cae67 into develop Jan 3, 2025
99 checks passed
@artemrys artemrys deleted the init-build-appinspect branch January 3, 2025 15:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants