Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dimmed as default disable method #1502

Merged
merged 13 commits into from
Dec 6, 2024

Conversation

soleksy-splunk
Copy link
Contributor

@soleksy-splunk soleksy-splunk commented Dec 3, 2024

Issue number:
N/A

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Allows users to use assistance technologies for disabled buttons and text fields.

Changes

Adapt to documentation suggestion to use "dimmed" option for disabled fields:
Text

Button

User experience

Users can navigate by disabled buttons and text fields by using tab.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

@soleksy-splunk soleksy-splunk requested a review from a team as a code owner December 3, 2024 16:19
@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 3, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 5, 2024
ui/src/components/EntityModal/EntityModal.test.tsx Outdated Show resolved Hide resolved
ui/jest.setup.ts Outdated Show resolved Hide resolved
ui/src/tests/expectExtenders.ts Outdated Show resolved Hide resolved
@soleksy-splunk soleksy-splunk merged commit 0c1ef99 into develop Dec 6, 2024
98 checks passed
@soleksy-splunk soleksy-splunk deleted the feat/use-dimmed-as-default-disable-method branch December 6, 2024 14:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants