feat: do not add _uccVersion to the root globalConfig file #1519
+70
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a test to capture this behavior? |
# Conflicts: # tests/testdata/test_addons/package_global_config_everything/globalConfig.json
hetangmodi-crest
approved these changes
Jan 3, 2025
artemrys
approved these changes
Jan 3, 2025
artemrys
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Summary
Changes
Now
_uccVersionis not added to the rootglobalConfig.json. Only to theappserver/static/js/build/globalConfig.json.If
_uccVersionis specified in the rootglobalConfig.json, it is removed.User experience
No
_uccVersionin the rootglobalConfig.json.Checklist
If an item doesn't apply to your changes, leave it unchecked.