Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: timeout control and python39 splunk tests include in matrix #192

Merged
merged 14 commits into from
Nov 9, 2023
Merged

fix: timeout control and python39 splunk tests include in matrix #192

merged 14 commits into from
Nov 9, 2023

Conversation

mkolasinski-splunk
Copy link
Contributor

@mkolasinski-splunk mkolasinski-splunk commented Nov 8, 2023 •
edited
Loading

Changes related to recently reported issues with tests running on unreleased Splunk with python 3.9

  1. Instead of relying on addonfactory-test-matrix, matrix elements are included in each test job to cover testing on splunk python3.9
  2. to avoid reaching github timeout limit 6hrs, causing uncontrolled workflow failure, steps capture-start-time and calculate-timeout are introduced to each test job. Their output is being used to determine timeout-minutes parameter for according steps.

Tested:

@mkolasinski-splunk mkolasinski-splunk requested a review from a team as a code owner November 8, 2023 13:45
@mkolasinski-splunk mkolasinski-splunk requested review from artemrys and mbruzda-splunk and removed request for artemrys November 8, 2023 13:45
artemrys
artemrys reviewed Nov 9, 2023
View reviewed changes
.github/workflows/reusable-build-test-release.yml
@@ -1908,11 +1955,17 @@ jobs:
- meta
- setup-workflow
runs-on: ubuntu-latest
continue-on-error: ${{ matrix.python39 }}
strategy:
fail-fast: false
matrix:
splunk: ${{ fromJson(needs.meta.outputs.matrix_supportedSplunk) }}
os: [ "ubuntu:14.04", "ubuntu:16.04","ubuntu:18.04","ubuntu:22.04", "centos:7", "redhat:8.0", "redhat:8.2", "redhat:8.3", "redhat:8.4", "redhat:8.5" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but we need to revisit this list.

artemrys
artemrys reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please run it on couple of more repositories (more complicated)?

@artemrys
Copy link
Member

artemrys commented Nov 9, 2023 •
edited
Loading

Can you please run it on couple of more repositories (more complicated)?

Run it on MSCS and AWS.

@artemrys artemrys merged commit f798dc5 into main Nov 9, 2023
6 checks passed
@artemrys artemrys deleted the fix/controlled-timeout branch November 9, 2023 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
@srv-rr-github-token
Copy link

🎉 This PR is included in version 4.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artemrys artemrys artemrys left review comments

@mbruzda-splunk mbruzda-splunk Awaiting requested review from mbruzda-splunk mbruzda-splunk is a code owner automatically assigned from splunk/products-gdi-addons-adminrepo

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkolasinski-splunk @artemrys @srv-rr-github-token