Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Adding version enforcement #280
Feature: Adding version enforcement #280
Changes from 4 commits
0f4ea67
001a309
651978f
63530a5
f0e71e9
6dd0a4b
87d128a
890a239
6826188
249bf27
dac23df
89e2473
1be4d87
0a7db93
dfbfc52
4cf3628
f00e886
44cbee7
094b4bb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmcginley-splunk , I am EXTREMELY tempted to remove the HTTP URLs for all of our apps and use this function to download them from Splunkbase on-demand. This makes it WAY easy to bump versions as we don't need to mirror a specific version of the app to S3.
The implementation for this would look something like:
a. specific version set? Use that version
b. specific version not set? Use latest version.
This is likely an enhancement and out of scope for this PR.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolving this as a possible enhancement: #284
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think consolidating under the
SplunkApp
umbrella is a great idea!