-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: validation of detections against cms_main #303
Open
cmcginley-splunk
wants to merge
16
commits into
main
Choose a base branch
from
feature/validation_against_cms_main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcginley-splunk
changed the title
Feature/validation against cms main
Feature: validation of detections against cms_main
Oct 8, 2024
…ing should be enforced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Code change
ContentVersioningService
cms_main
and detections based on YAMLs matchcms_event
cms_event
can be matched to a detectioncms_event
is repeatedDetectionTestingInfrastructure
raise
any exceptions that crop up during setup, instead of just logging themDetectionTestingInfrastructure
to query installed ES version, so we can determine when it is appropriate to run content versioning validationAll
CorrelationSearch
(useful for debugging) tohelper.utils.Utils
so it could be re-used inContentVersioningService
Testing
savedsearches.conf
file and all seems to work wellCaveats
cms_main
index should happen in aggregate, a test of the whole package, not individual detections. We do not have an easy way to insert testing at that level presently.TODOs