Exception on extra fields #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that was accidentally dropped. set extra='forbid' for SecurityContentObject
… should not be in the yml
to computed_field
field for investigation
pydantic object definitions.
|
Just updated this with main- if you want to temporarily run the Just pass it your security_content branch, and then after a full run of green, feel free to take it out. |
new template. Added drilldowns, if appropriate, and made the link to attack_data set invalid, so that if it is not updated it fails validation. This prevents an incorrect attack_data from failing silently.
temporarily, to test against relevant updated content
repo reference
Bump version of contentctl to v4.5.0 in prep for release.
repeatable value when a field has not been updated. Provide more context for enum fields as to what can be set. Finally, throw an error during YML read if an un-UPDATED field still exists in any of the YMLs.
Remove extra pair of quotes from new detection template
version to resolve bug in our code
ljstella
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an exception if extra fields are included in YML files.
This results is much cleaner files and catching typos in field names.
Note that this removed
datamodelfield frmo some files in favor of making it a computed_field, as it has been for some time for detections.The following security_content PR fixes outstanding issues with content and should be merged first: splunk/security_content#3202
This PR also significantly cleans up the code for the
contentctl newworkflow.