Deprecate unused BUSYBOX_URL variable #669
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the most recent commit, 0de4bff, I can see that the URL to download Busybox into the RHEL 8 UBI container is being hard-coded into the
install.sh
script:docker-splunk/base/redhat-8/install.sh
Line 45 in 0de4bff
This seems to deprecate the previous lines:
docker-splunk/base/redhat-8/install.sh
Lines 81 to 83 in 07a7c86
It seems like this was mainly being used in the Makefile for the armv8 RHEL8 container, passed in as a build-arg, which overrode the default:
docker-splunk/Makefile
Lines 77 to 78 in 0de4bff
I guess this needed overriding for the armv8 container since Busybox don't seem to publish
aarch64
builds at that URL above.But now, as of 0de4bff, we're building from source and not actually using the
$BUSYBOX_URL
variable anywhere, this is having no effect even if we do pass it in as a build-arg. So for clarity, we might as well remove the variable entirely.