Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing wildcard to -type parameter for detection 2452e632-9e0d-11eb-bacd-acde48001122 #3170

Conversation

Wouter-Jansen
Copy link
Contributor

@Wouter-Jansen Wouter-Jansen commented Oct 22, 2024

The detection won't hit on e.g. "nslookup.exe -type=MX" without the leading wildcard

Details

This PR adds a leading wildcard to the -type parameter for nslookup.exe. Without that wildcard the -type parameter will never create a hit. All other parameters do have both a leading and trailing wildcard.

Checklist

  • CI/CD jobs passed ✔️
  • Validated SPL logic.

Notes For Submitters and Reviewers

  • If you're submitting a PR from a fork, ensuring the box to allow updates from maintainers is checked will help speed up the process of getting it merged.
  • Checking the output of the build CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.
  • Updates to existing lookup files can be tricky, because of how Splunk handles application updates and the differences between existing lookup files being updated vs new lookups. You can read more here but the short version is that any changes to lookup files need to bump the datestamp in the lookup CSV filename, and the reference to it in the YAML needs to be updated.

Closes #3171

The detection won't hit on e.g. "nslookup.exe -type=MX" without the leading wildcard
@patel-bhavin
Copy link
Contributor

Awesome! Thank you for fixing this @Wouter-Jansen. As a request can you bump the version and the date of the detection yaml and please feel free to add your name to the detection as well since you help make it better!

Copy link
Contributor

@ljstella ljstella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:shipit:

Thanks again for the contribution!

@patel-bhavin patel-bhavin merged commit e27cf3b into splunk:develop Oct 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing wildcard for -type parameter detection 2452e632-9e0d-11eb-bacd-acde48001122
3 participants