remove endhoursago=1 from drilldown searches #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyth0n1c
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Despite the first apparent failure, the search GPUpdate with no Command Line Arguments with Network passes when retesting:
The second failed search Potentially malicious code on commandline passes after installing Python for Scientific Computing. I recommend adding this to our testing baseline. Note this this is a more time-consuming app to install. Here is evidence of the search passing:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove endhoursago=1 as it doesnt work on our testing. Rely on$info_max_time$ for the latest offset. Screenshot to show the _time span (highlighted)
Also update name for better formatting on Incident Review