Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add yamllint #1032

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix/add yamllint #1032

merged 1 commit into from
Jul 1, 2024

Conversation

wojtekzyla
Copy link
Collaborator

@wojtekzyla wojtekzyla commented Jun 25, 2024

Description

Added yamllint configuration file. Profiles and groups validation added to the code.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Refactor/improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

New integration tests

Checklist

  • My commit message is conventional
  • I have run pre-commit on all files before creating the PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

docs/bestpractices.md Outdated Show resolved Hide resolved
docs/bestpractices.md Outdated Show resolved Hide resolved
docs/bestpractices.md Outdated Show resolved Hide resolved
docs/bestpractices.md Outdated Show resolved Hide resolved
docs/gettingstarted/sc4snmp-installation.md Outdated Show resolved Hide resolved
docs/gettingstarted/sc4snmp-installation.md Outdated Show resolved Hide resolved
docs/gettingstarted/sc4snmp-installation.md Outdated Show resolved Hide resolved
docs/gettingstarted/sc4snmp-installation.md Outdated Show resolved Hide resolved
integration_tests/test_poller_integration.py Show resolved Hide resolved
@wojtekzyla wojtekzyla requested a review from ajasnosz June 28, 2024 12:58
Copy link
Collaborator

@ajasnosz ajasnosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update changelog

docs/bestpractices.md Outdated Show resolved Hide resolved
docs/bestpractices.md Outdated Show resolved Hide resolved
fix: add validation of profiles and groups configuration
@wojtekzyla wojtekzyla merged commit 9895687 into develop Jul 1, 2024
10 of 11 checks passed
@wojtekzyla wojtekzyla deleted the fix/add-yamllint branch July 1, 2024 11:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 1.11.0-beta.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants