Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more deployment endpoint code to Service #158

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vegitron
Copy link

  • Fixes the URL for PATH_DEPLOYMENT_SERVERCLASSES
  • Exposes deployment_apps, deployment_clients and server_classes in the Service class
  • Adding virtualenv related entries to .gitignore

* Fixes the URL for PATH_DEPLOYMENT_SERVERCLASSES
* Exposes deployment_apps, deployment_clients and server_classes in the Service class
* Adding virtualenv related entries to .gitignore
@shakeelmohamed
Copy link
Contributor

Thanks for the PR @vegitron!
From 1-5, how urgently do you need this released?

@vegitron
Copy link
Author

Probably a 3. We can do a pip install from my github fork for a while if needed.

Is the failing test something I should worry about? It doesn't look like it's related to my changes.

@shakeelmohamed
Copy link
Contributor

@vegitron OK, we appreciate the flexibility. The test failure is a recent regression around SSL certs, it's unrelated to your changes

@fantavlik fantavlik self-requested a review January 19, 2022 17:48
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you are still following this PR but if so this generally looks good - just a few small changes, resolving merge conflicts with the latest changes in develop and adding a tests to verify the functionality would allow us to merge this. Otherwise we can put this work on hold if someone else is able to pick it back up.

class DeploymentApps(Collection):
"""This class represents a collection of deployment apps."""
def __init__(self, service):
Collection.__init__(self, service, PATH_DEPLOYMENT_APPS, item=ServerClass)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant item= DeploymentApp

class DeploymentClient(Collection):
"""This class represents a collection of deployment clients."""
def __init__(self, service):
Collection.__init__(self, service, PATH_DEPLOYMENT_CLIENTS, item=ServerClass)
Copy link
Contributor

@fantavlik fantavlik Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to change the name of the collection to DeploymentClients (plural) and this line to item=DeploymentClient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants