Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add bigdecimal to Gemfile #533

Merged
merged 1 commit into from
May 22, 2024

Conversation

m-nakamura145
Copy link
Contributor

From Ruby 3.4 onwards, gems that are expected to become bundled gems will raise a LoadError if they are required without being present in the Gemfile or gemspec. Therefore, I have added the target gem to the Gemfile.

/addressable/spec/addressable/template_spec.rb:20: warning: bigdecimal was loaded from the standard library, but is not part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec.

An error occurred while loading ./spec/addressable/template_spec.rb. - Did you mean?
                    rspec ./spec/addressable/idna_spec.rb
                    rspec ./spec/addressable/uri_spec.rb
                    rspec ./spec/addressable/security_spec.rb

Failure/Error: require "bigdecimal"

LoadError:
  cannot load such file -- bigdecimal
# ./spec/addressable/template_spec.rb:20:in '<top (required)>'

@@ -89,6 +89,7 @@ jobs:
- 3.1
- 3.2
- 3.3
- 3.4.0-preview1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to add this preview version, we have a job for head, which now is ruby 3.4.0dev (https://github.com/sporkmonger/addressable/actions/runs/9173838413/job/25223381402#step:5:25)

Last time that job ran was 4 months ago, so I suspect the bigdecimal change had not happen yet as it passed back then (but the logs are now gone)

Gemfile Outdated
@@ -5,6 +5,7 @@ source 'https://rubygems.org'
gemspec

group :test do
gem 'bigdecimal'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to make this work for the jobs that are failing

@m-nakamura145 m-nakamura145 changed the title Support ruby 3.4.0-preview1 Add bigdecimal to Gemfile May 22, 2024
@dentarg dentarg merged commit 1a09707 into sporkmonger:main May 22, 2024
34 checks passed
@m-nakamura145 m-nakamura145 deleted the support-ruby-3-4-0-preview1 branch May 22, 2024 10:12
@dentarg dentarg changed the title Add bigdecimal to Gemfile CI: add bigdecimal to Gemfile Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants