Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change owasp 2013 to owasp 2017 #238

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

change owasp 2013 to owasp 2017 #238

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d168f2
change owasp 2013 to owasp 2017
LeGrandMaxime Dec 21, 2018
9bd0100
add description owasp 2017
LeGrandMaxime Jan 2, 2019
5b784ec
Merge branch 'master' into master-release
h3xstream Aug 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 7 additions & 25 deletions generate_profiles/BuildXmlFiles.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,41 +122,23 @@ def writeRules(String rulesSetName,List<Plugin> plugins,List<String> includedBug
configKey(pattern.attribute("type"))
description(pattern.Details.text().trim())

//OWASP TOP 10 2013
if (pattern.Details.text().toLowerCase().contains('injection') || pattern.Details.text().contains('A1-Injection')) {
//OWASP TOP 10 2017
if (pattern.Details.text().toLowerCase().contains('injection') || pattern.Details.text().contains('2017_A1-Injection')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: The second condition is redundant. The first will always match first.

I would not require a change. The code might be clearer this way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized it was already like that.. nvm.

tag("owasp-a1")
tag("injection")
}
if (pattern.Details.text().contains('A2-Broken_Authentication_and_Session_Management')) {
tag("owasp-a2")
}
if (pattern.attribute("type").contains("XSS") || pattern.Details.text().contains('A3-Cross-Site_Scripting')) {
tag("owasp-a3")
}
if (pattern.Details.text().contains('A4-Insecure_Direct_Object_References') || pattern.Details.text().contains('Path_Traversal')) {
tag("owasp-a4")
if (pattern.attribute("type").contains("XSS") || pattern.Details.text().contains('2017_A7-Cross-Site_Scripting')) {
tag("owasp-a7")
}
if (pattern.Details.text().contains('A5-Security_Misconfiguration')) {
if (pattern.Details.text().contains('Path_Traversal')) {
tag("owasp-a5")
}
if (pattern.attribute('type').equals('HARD_CODE_PASSWORD') ||
pattern.attribute("type") in cryptoBugs ||
pattern.Details.text().contains('A6-Sensitive_Data_Exposure')) {
tag("owasp-a6")
pattern.Details.text().contains('2017_A3-Sensitive_Data_Exposure')) {
tag("owasp-a3")
tag("cryptography")
}
if (pattern.Details.text().contains('A7-Missing_Function_Level_Access_Control')) {
tag("owasp-a7")
}
if (pattern.Details.text().toLowerCase().contains('A8-Cross-Site_Request_Forgery')) {
tag("owasp-a8")
}
if (pattern.Details.text().toLowerCase().contains('A9-Using_Components_with_Known_Vulnerabilities')) {
tag("owasp-a9")
}
if (pattern.Details.text().toLowerCase().contains('A10-Unvalidated_Redirects_and_Forwards')) {
tag("owasp-a10")
}

//Misc tags

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<groupId>com.github.spotbugs</groupId>
<artifactId>sonar-findbugs-plugin</artifactId>
<version>3.10.0-SNAPSHOT</version>
<version>3.11-SNAPSHOT</version>
<packaging>sonar-plugin</packaging>

<name>SonarQube SpotBugs Plugin</name>
Expand Down
4 changes: 2 additions & 2 deletions src/main/resources/org/sonar/plugins/findbugs/rules-findbugs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ If SpotBugs found &lt;em&gt;any&lt;/em&gt;, you &lt;em&gt;almost certainly&lt;/e
vulnerabilities that SpotBugs doesn't report. If you are concerned about cross site scripting, you should seriously
consider using a commercial static analysis or pen-testing tool.
&lt;/p&gt;</description>
<tag>owasp-a3</tag>
<tag>owasp-a7</tag>
<tag>security</tag>
</rule>
<rule key='XSS_REQUEST_PARAMETER_TO_SEND_ERROR' priority='MAJOR'>
Expand All @@ -165,7 +165,7 @@ If SpotBugs found &lt;em&gt;any&lt;/em&gt;, you &lt;em&gt;almost certainly&lt;/e
vulnerabilities that SpotBugs doesn't report. If you are concerned about cross site scripting, you should seriously
consider using a commercial static analysis or pen-testing tool.
&lt;/p&gt;</description>
<tag>owasp-a3</tag>
<tag>owasp-a7</tag>
<tag>security</tag>
</rule>
<rule key='SW_SWING_METHODS_INVOKED_IN_SWING_THREAD' priority='MAJOR'>
Expand Down
Loading