Merge pull request #38 from spotify/handle-stale-provider

Handle ProviderStale event
spotify · Jul 31, 2023 · f352203 · f352203
2 parents c063d16 + a549249
commit f352203
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/OpenFeature/src/main/java/dev/openfeature/sdk/events/EventHandler.kt b/OpenFeature/src/main/java/dev/openfeature/sdk/events/EventHandler.kt
@@ -37,6 +37,7 @@ class EventHandler(dispatcher: CoroutineDispatcher) : EventObserver, EventsPubli
             sharedFlow.collect {
                 when (it) {
                     is OpenFeatureEvents.ProviderReady -> isProviderReady.value = true
+                    is OpenFeatureEvents.ProviderStale -> isProviderReady.value = false
                     is OpenFeatureEvents.ProviderShutDown -> {
                         isProviderReady.value = false
                         job.cancelChildren()

diff --git a/OpenFeature/src/main/java/dev/openfeature/sdk/events/OpenFeatureEvents.kt b/OpenFeature/src/main/java/dev/openfeature/sdk/events/OpenFeatureEvents.kt
@@ -2,7 +2,6 @@ package dev.openfeature.sdk.events
 
 sealed class OpenFeatureEvents {
     object ProviderReady : OpenFeatureEvents()
-    object ProviderConfigurationChanged : OpenFeatureEvents()
     data class ProviderError(val error: Throwable) : OpenFeatureEvents()
     object ProviderStale : OpenFeatureEvents()
     object ProviderShutDown : OpenFeatureEvents()

diff --git a/OpenFeature/src/test/java/dev/openfeature/sdk/EventsHandlerTest.kt b/OpenFeature/src/test/java/dev/openfeature/sdk/EventsHandlerTest.kt
@@ -151,6 +151,27 @@ class EventsHandlerTest {
         Assert.assertTrue(isProviderReady)
     }
 
+    @Test
+    fun the_provider_becomes_stale() = runTest {
+        val eventPublisher = EventHandler.eventsPublisher()
+        var isProviderStale = false
+
+        val job = backgroundScope.launch(UnconfinedTestDispatcher(testScheduler)) {
+            EventHandler.eventsObserver()
+                .observe<OpenFeatureEvents.ProviderStale>()
+                .take(1)
+                .collect {
+                    isProviderStale = true
+                }
+        }
+
+        eventPublisher.publish(OpenFeatureEvents.ProviderReady)
+        eventPublisher.publish(OpenFeatureEvents.ProviderStale)
+        job.join()
+
+        Assert.assertTrue(isProviderStale)
+    }
+
     @Test
     fun observe_string_value_from_client_works() = runTest {
         val testDispatcher = UnconfinedTestDispatcher(testScheduler)