Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more default jdkAddOpenModules for Java 17+ #5538

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

clairemcginty
Copy link
Contributor

Open more modules, based off of Kryo-related errors we've seen, as well as the set of modules opened by Flink.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.50%. Comparing base (d4b1ced) to head (1cd1b88).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5538      +/-   ##
==========================================
+ Coverage   61.44%   61.50%   +0.06%     
==========================================
  Files         312      312              
  Lines       11105    11122      +17     
  Branches      776      779       +3     
==========================================
+ Hits         6823     6841      +18     
+ Misses       4282     4281       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clairemcginty clairemcginty merged commit 2b32122 into main Jan 9, 2025
12 checks passed
@clairemcginty clairemcginty deleted the more-java-add-opens branch January 9, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants