fixed tolerations #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalShafir
previously approved these changes
Feb 21, 2024
| @@ -48,11 +34,11 @@ helm install my-release spot/ocean-network-client | |||
| | image.pullSecrets | Optional | `[]` | Image pull secrets. | | |||
| | image.repository | Optional | `"public.ecr.aws/spotinst/spot-network-client"` | Image repository. | | |||
| | image.tag | Optional | `""` | Image tag. Defaults to `.Chart.AppVersion`. | | |||
| | namespace | Optional | `"kube-system"` | Namespace where components should be installed. | | |||
| | namespace | string | `"kube-system"` | | | |||
There was a problem hiding this comment.
@TalShafir @rkrmr33 We have to support different ns for the network-client (since the old controller enabled it, not sure what happens with the new one)
Does the current definition mean that the default ns is kube-system, but we can overwrite it?
TalShafir
approved these changes
Feb 22, 2024
oded7hoffman
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the default pull request template. You can customize it by adding a
pull_request_template.mdat the root of your repo or inside the.githubfolder.Jira Ticket
Include a link to your Jira Ticket
Example: JIRAISS-1234
Demo
Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route
Checklist: