Use runtime configuration for admin_path #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete-merged-branch
bot
deleted the
feature/use_runtime_configuration_for_admin_path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some preferences like
admin_pathcannot be changed dynamically in a running application, therefore it doesn't make sense to persist them in the database.This PR follows-up on https://github.com/spree/spree/pull/11965/files , which introduced a
RuntimeConfigurationclass, and movesadmin_path(that's used when defining routes upon application boot) andadmin_show_version(which I think doesn't really make sense to be dynamically configurable, but I'm open to discuss that).