AdminClient customizer #1023
AdminClient customizer #1023
Conversation
Provide the ability for applications to customize AdminClient by introducing a new interface AdminClientConfigCustomizer. Resolves spring-attic#1014
There was a problem hiding this comment.
I wonder if we should add the binding name to these customizer interfaces and customize a new set of properties for each binding?
Perhaps another issue, though, for a future release.
Another issue is how can they tell which binder is being customized when named binders are being used. I suppose they can use the broker addresses to determine it, but perhaps it would be nice to pass them the binder name. Again, new feature, perhaps.
docs/src/main/asciidoc/overview.adoc
Outdated
| [[admin-client-config-customization]] | ||
| === Customizing AdminClient Configuration | ||
|
|
||
| As with consumer and producer config customization above, applications can also customize the configuration for admin client by providing an AdminClientConfigCustomizer. |
There was a problem hiding this comment.
| As with consumer and producer config customization above, applications can also customize the configuration for admin client by providing an AdminClientConfigCustomizer. | |
| As with consumer and producer config customization above, applications can also customize the configuration for admin clients by providing an `AdminClientConfigCustomizer`. |
There was a problem hiding this comment.
Good points about the bindings/binder names. Issue created.
There was a problem hiding this comment.
I meant all the customizers (producer, consumer) not just the admin.
| @@ -97,7 +100,7 @@ public void testAutoCreateTopicDisabledFailsOnProducerIfTopicNonExistentOnBroker | |||
| configurationProperties.getConfiguration().put("max.block.ms", "3000"); | |||
|
|
|||
| KafkaTopicProvisioner provisioningProvider = new KafkaTopicProvisioner( | |||
| configurationProperties, kafkaProperties); | |||
| configurationProperties, kafkaProperties, adminClientConfigCustomizer); | |||
There was a problem hiding this comment.
It's not clear why we're changing this test since we aren't verifying that the customizer was called. It's already covered by an earlier test.
Ditto the next test.
Provide the ability for applications to customize AdminClient by
introducing a new interface AdminClientConfigCustomizer.
Resolves #1014