Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Angular OAuth2 login page #1923

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

klopfdreh
Copy link
Contributor

@klopfdreh klopfdreh commented May 19, 2023

Address the issue: #1887

When OAuth2 is enabled and there are client-registrations with authorization-grand-type authorization_code all those are going to be listed within the Angular-Login, now. Also when you logout and login again you are redirected correctly.

❗There is one thing required to be fixed. Please refer to the backend issue for that. (See: spring-cloud/spring-cloud-dataflow#5350)

See:

Bildschirmfoto 2023-05-19 um 12 38 34

and:

Bildschirmfoto 2023-05-19 um 12 34 28

and:

Bildschirmfoto 2023-05-19 um 12 30 38

@klopfdreh
Copy link
Contributor Author

The issue within the backend is solved now. I would suggest to wait till the backend implementation has been integrated and then merge this one as far as this is also fine for you.

You are able to switch between the default spring-security oauth2 login:

login-url: "/login"

and the new login form provided via Angular with:

login-url: "/dashboard/index.html#/authentication-required"

@ilayaperumalg ilayaperumalg added this to the 3.4.x milestone Dec 11, 2023
@cppwfs cppwfs modified the milestones: 3.4.x, 4.0.x Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants