Skip to content

Commit

Permalink
Use new Prometheus client (1.x) (#6090)
Browse files Browse the repository at this point in the history
Replaces the `micrometer.io:micrometer-registry-prometheus-simpleclient`
with `micrometer.io:micrometer-registry-prometheus`.

Also updates the Prometheus RSocket version from `2.0.0-M3`
to `2.0.0-M4`.

See #6068
See #6069
  • Loading branch information
onobc authored Dec 19, 2024
1 parent 0c63ca5 commit 0931f1e
Show file tree
Hide file tree
Showing 14 changed files with 14 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<commons-compress.version>1.26.2</commons-compress.version>
<!-- Specific version overrides to deal w/ CVEs -->
<nimbus-jose-jwt.version>9.39.3</nimbus-jose-jwt.version>
<prometheus-rsocket.version>2.0.0-M2</prometheus-rsocket.version>
<prometheus-rsocket.version>2.0.0-M4</prometheus-rsocket.version>
<java-cfenv.version>2.3.0</java-cfenv.version>
<spring-cloud-services-starter-config-client.version>3.5.4</spring-cloud-services-starter-config-client.version>
<kubernetes-fabric8-client.version>5.12.4</kubernetes-fabric8-client.version>
Expand Down
2 changes: 1 addition & 1 deletion spring-cloud-dataflow-composed-task-runner/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
</dependency>
<dependency>
<groupId>io.micrometer</groupId>
<artifactId>micrometer-registry-prometheus-simpleclient</artifactId>
<artifactId>micrometer-registry-prometheus</artifactId>
</dependency>
<dependency>
<groupId>io.micrometer.prometheus</groupId>
Expand Down
2 changes: 1 addition & 1 deletion spring-cloud-dataflow-server-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
</dependency>
<dependency>
<groupId>io.micrometer</groupId>
<artifactId>micrometer-registry-prometheus-simpleclient</artifactId>
<artifactId>micrometer-registry-prometheus</artifactId>
</dependency>
<dependency>
<groupId>io.micrometer.prometheus</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
</dependency>
<dependency>
<groupId>io.micrometer</groupId>
<artifactId>micrometer-registry-prometheus-simpleclient</artifactId>
<artifactId>micrometer-registry-prometheus</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.cloud</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
</dependency>
<dependency>
<groupId>io.micrometer</groupId>
<artifactId>micrometer-registry-prometheus-simpleclient</artifactId>
<artifactId>micrometer-registry-prometheus</artifactId>
</dependency>
<dependency>
<groupId>io.micrometer.prometheus</groupId>
Expand Down
2 changes: 1 addition & 1 deletion src/carvel/config/values/values.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,5 +112,5 @@ scdf:
enabled: false
image:
repository: micrometermetrics/prometheus-rsocket-proxy
tag: 2.0.0-M2
tag: 2.0.0-M4
digest: ""
2 changes: 1 addition & 1 deletion src/carvel/docs/configuration-options.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ No
Type:::
String
Default Value:::
2.0.0-M2
2.0.0-M4

[[configuration-options-scdf.feature.monitoring.prometheusRsocketProxy.image.digest]]`scdf.feature.monitoring.prometheusRsocketProxy.image.digest`::
Description:::
Expand Down
2 changes: 1 addition & 1 deletion src/deploy/carvel/load-images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ else
sh "$K8S/load-image.sh" "springcloud/spring-cloud-dataflow-server" "$DATAFLOW_VERSION" true
fi
if [ "$PROMETHEUS" = "true" ]; then
sh "$K8S/load-image.sh" "micrometermetrics/prometheus-rsocket-proxy" "2.0.0-M2" false
sh "$K8S/load-image.sh" "micrometermetrics/prometheus-rsocket-proxy" "2.0.0-M4" false
fi
if [ "$REGISTRY" = "" ]; then
REGISTRY=springcloud
Expand Down
2 changes: 1 addition & 1 deletion src/deploy/images/pull-prometheus-rsocket-proxy.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
docker pull "micrometermetrics/prometheus-rsocket-proxy:2.0.0-M2"
docker pull "micrometermetrics/prometheus-rsocket-proxy:2.0.0-M4"
2 changes: 1 addition & 1 deletion src/deploy/k8s/deploy-scdf.sh
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ if [ "$PROMETHEUS" = "true" ] || [ "$METRICS" = "prometheus" ]; then
if [ "$K8S_DRIVER" != "tmc" ] && [ "$K8S_DRIVER" != "gke" ]; then
sh "$SCDIR/load-image.sh" "springcloud/spring-cloud-dataflow-grafana-prometheus:$DATAFLOW_VERSION" false
sh "$SCDIR/load-image.sh" "prom/prometheus:v2.37.8"
sh "$SCDIR/load-image.sh" "micrometermetrics/prometheus-rsocket-proxy:2.0.0-M2"
sh "$SCDIR/load-image.sh" "micrometermetrics/prometheus-rsocket-proxy:2.0.0-M4"
fi
set +e
kubectl create --namespace "$NS" serviceaccount prometheus-rsocket-proxy
Expand Down
2 changes: 1 addition & 1 deletion src/docker-compose/docker-compose-prometheus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ services:
#- SPRING_APPLICATION_JSON={"spring.jpa.properties.hibernate.generate_statistics":true}

prometheus-rsocket-proxy:
image: micrometermetrics/prometheus-rsocket-proxy:2.0.0-M2
image: micrometermetrics/prometheus-rsocket-proxy:2.0.0-M4
container_name: prometheus-rsocket-proxy
expose:
- '9096'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
serviceAccountName: prometheus-rsocket-proxy
containers:
- name: prometheus-rsocket-proxy
image: micrometermetrics/prometheus-rsocket-proxy:2.0.0-M2
image: micrometermetrics/prometheus-rsocket-proxy:2.0.0-M4
imagePullPolicy: IfNotPresent
ports:
- name: scrape
Expand Down
2 changes: 1 addition & 1 deletion src/templates/docker-compose/docker-compose-prometheus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ services:
#- SPRING_APPLICATION_JSON={"spring.jpa.properties.hibernate.generate_statistics":true}

prometheus-rsocket-proxy:
image: micrometermetrics/prometheus-rsocket-proxy:2.0.0-M2
image: micrometermetrics/prometheus-rsocket-proxy:2.0.0-M4
container_name: prometheus-rsocket-proxy
expose:
- '9096'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
serviceAccountName: prometheus-rsocket-proxy
containers:
- name: prometheus-rsocket-proxy
image: micrometermetrics/prometheus-rsocket-proxy:2.0.0-M2
image: micrometermetrics/prometheus-rsocket-proxy:2.0.0-M4
imagePullPolicy: IfNotPresent
ports:
- name: scrape
Expand Down

0 comments on commit 0931f1e

Please sign in to comment.