Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add develocity configuration. #5821

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

corneil
Copy link
Contributor

@corneil corneil commented May 21, 2024

Issue #5779

We will add profile for doing buildscan.

@corneil corneil requested review from cppwfs and onobc May 21, 2024 13:40
Copy link
Contributor

@cppwfs cppwfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue for the addition of this feature?
That way we can explain why it is being added.

Thanks!

Correction... I see the issue. Apologies for the noise.

<url>https://ge.spring.io</url>
</server>
<buildScan>
<backgroundBuildScanUpload>false</backgroundBuildScanUpload>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we want to run on a schedule or every time?
Have we tested how much time this will add to our CI builds?

</server>
<buildScan>
<backgroundBuildScanUpload>false</backgroundBuildScanUpload>
<captureGoalInputFiles>true</captureGoalInputFiles>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to set the projectId i.e. <projectId>SC-DataFlow</projectId>

<obfuscation>
<ipAddresses>#{{'0.0.0.0'}}</ipAddresses>
</obfuscation>
</buildScan>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have this on our CI Builds or also on releases? If so do we want to use tags?

    <tags>
      <tag>my tag</tag>
    </tags>

@onobc
Copy link
Contributor

onobc commented May 22, 2024

Issue #5779

We will add profile for doing buildscan.

This may be helpful to the reviewer: https://docs.gradle.com/develocity/maven-extension/current/

@cppwfs
Copy link
Contributor

cppwfs commented May 22, 2024

We probably want to have a chat on how we want to configure it. I think that is the gist of my questions, "how should this be configured?"

@cppwfs cppwfs added this to the 3.0.x milestone May 29, 2024
@corneil corneil force-pushed the main branch 2 times, most recently from c0462f2 to f0fb797 Compare August 8, 2024 11:55
@cppwfs cppwfs removed this from the 3.0.x milestone Sep 5, 2024
@cppwfs cppwfs added the status/on-hold For various reasons is on hold label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/on-hold For various reasons is on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants